Skip to content

fix: enable strict mode for TypeScript #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

ojeytonwilliams
Copy link
Contributor

  • refactor: strict types for index.ts
  • refactor: fix types for parse and node

Checklist:

Closes #XXXXX

@ojeytonwilliams ojeytonwilliams marked this pull request as ready for review January 24, 2024 11:01
@ojeytonwilliams ojeytonwilliams requested a review from a team as a code owner January 24, 2024 11:01
@ojeytonwilliams
Copy link
Contributor Author

Going through this made it obvious just how little of strip-comments we actually use.

We should expand our tests a little (since we're implicitly relying on a bunch of tests in https://github.com/jonschlinkert/strip-comments that we don't run) and remove everything we don't need, but I'll do that in another PR.

Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ojeytonwilliams ojeytonwilliams merged commit 06ea1ae into freeCodeCamp:main Jan 29, 2024
@ojeytonwilliams ojeytonwilliams deleted the fix/script-ts branch January 29, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants