PHP 7.2 compatibility #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enumag
reviewed
Dec 27, 2017
| { | ||
|
|
||
| use Nette\SmartObject; |
There was a problem hiding this comment.
I think we need to raise version constraint for nette as well. This trait does not exist in older versions.
There was a problem hiding this comment.
Fixed. Totally forgot because of missing dependency.
enumag
reviewed
Dec 27, 2017
composer.json
Outdated
| "nette/di": "~2.2", | ||
| "nette/http": "~2.2", | ||
| "nette/utils": "~2.4", |
There was a problem hiding this comment.
Not sure if nette/di 2.2 will work with nette/utils 2.4. Better raise all nette dependencies to 2.4 in my opinion.
There was a problem hiding this comment.
Ok, did it. Hope this is last commit for that change :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.