Skip to content

Conversation

@MrCroxx
Copy link
Member

@MrCroxx MrCroxx commented Jun 24, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

rm -rf /6536/foyer && cargo build --release && RUST_BACKTRACE=1 RUST_LOG=info ./target/release/foyer-bench --dir /6536/foyer --mem 64 --disk 102400 --file-size 64 --get-range 10000 --flushers 4 --reclaimers 4 --time 60 --writers 256 --w-rate 4 --admission-rate-limit 500 --readers 1024 --r-rate 1 --runtime --compression none --distribution zipf --distribution-zipf-s 0.8 --metrics --eviction lru

vs

... --thread-local-cache-capacity 4
image

There is regression on baseline. I'll fix it later.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#566

@MrCroxx MrCroxx added feature New feature or request perf Performance optimization labels Jun 24, 2024
@MrCroxx MrCroxx added this to the v0.10 milestone Jun 24, 2024
@MrCroxx MrCroxx self-assigned this Jun 24, 2024
@codecov
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 49.23077% with 33 lines in your changes missing coverage. Please review.

Project coverage is 85.77%. Comparing base (c764af3) to head (d3dc2f4).

Files Patch % Lines
foyer-memory/src/local.rs 0.00% 29 Missing ⚠️
foyer-memory/src/generic.rs 76.92% 3 Missing ⚠️
foyer-bench/src/main.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   86.09%   85.77%   -0.33%     
==========================================
  Files          59       60       +1     
  Lines        7589     7653      +64     
==========================================
+ Hits         6534     6564      +30     
- Misses       1055     1089      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx modified the milestones: v0.10, v0.11 Jul 1, 2024
@MrCroxx MrCroxx modified the milestones: v0.11, v0.12 Aug 21, 2024
@MrCroxx MrCroxx modified the milestones: v0.12, Planning Oct 8, 2024
@MrCroxx MrCroxx force-pushed the main branch 2 times, most recently from 3f7f53f to c009129 Compare September 12, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request perf Performance optimization

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants