rust: fix int underflow when chunk wasn't closed #1480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nionata
reviewed
Nov 4, 2025
| let next = reader.next_event().expect("there should be one event"); | ||
|
|
||
| // test fails with unexpected EOC because sizes are u64::max | ||
| assert_matches!(next, Err(McapError::UnexpectedEoc)); |
There was a problem hiding this comment.
Say the file writer flushed the chunk after this call. Would reader.next_event yield data? Or is the reader borked after an error like this?
Contributor
Author
There was a problem hiding this comment.
In general once the reader hits an error it is considered to be in an invalid state. So it will be borked after this.
|
Thanks for the quick fix! |
jtbandes
approved these changes
Nov 4, 2025
james-rms
approved these changes
Nov 4, 2025
|
@bennetthardwick when will this be released to crates.io? |
Contributor
Author
|
@nionata I'll cut a release now 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Docs
None
Description
When a chunk doesn't close correctly (loss of power, crash, etc.) the size that was written will be
u64::MAX. If you try and read a file like this with the Rust reader it breaks because the size of the chunk is expected to be valid. In debug mode this will panic due to underflow, in release mode this value will wrap and break something else down the track.This change explicitly uses checked calculations for the chunk size and returns an
UnexpectedEocerror if any of the calculations overflow.Fixes #1479.
Fixes FIRE-202.