Skip to content

Conversation

@ethanmusser
Copy link
Contributor

@ethanmusser ethanmusser commented Aug 27, 2025

Changelog

Add a brief blurb and badge referencing the new vcpkg port for mcap in the README.md.

Docs

None

Description

A vcpkg port is in the works in microsoft/vcpkg#47084. This change calls out that port in the README.md so that new users are aware that it exists.

Draft TODOs

@ethanmusser ethanmusser marked this pull request as ready for review September 9, 2025 14:50
@james-rms
Copy link
Collaborator

The vcpkg package is not supported by this repo's maintainers, so I don't think it makes sense to link out to it as if it were. I can work on some wording to call it out as a third-party project in the README.

@james-rms
Copy link
Collaborator

Closing in favor of #1451

@james-rms james-rms closed this Sep 9, 2025
@ethanmusser
Copy link
Contributor Author

The vcpkg package is not supported by this repo's maintainers, so I don't think it makes sense to link out to it as if it were. I can work on some wording to call it out as a third-party project in the README.

@james-rms Thanks for putting the link in the README! As an aside, is there any chance of seeing an officially-maintained vcpkg port alongside the already-maintained Conan package?

@ethanmusser ethanmusser deleted the ethanmusser/vcpkg-port-documentation branch September 9, 2025 17:08
@james-rms
Copy link
Collaborator

@ethanmusser not at this time. CMake wrappers are difficult to provide a good user experience for, since everyone needs something a little different there. The goal of the first-party MCAP C++ library is to be easy to integrate into whatever build system you need, CMake or otherwise.

@ethanmusser
Copy link
Contributor Author

@ethanmusser not at this time. CMake wrappers are difficult to provide a good user experience for, since everyone needs something a little different there. The goal of the first-party MCAP C++ library is to be easy to integrate into whatever build system you need, CMake or otherwise.

Darn, figured it was worth asking. I will say that the approach in olympus-robotics/mcap_builder is pretty close to standard as far as vendoring a header-only CMake library like this one (with the #define MCAP_IMPLEMENTATION define). But totally understood, thanks for the consideration and for calling out the third-party vcpkg port!

james-rms added a commit that referenced this pull request Sep 9, 2025
### Changelog
<!-- Write a one-sentence summary of the user-impacting change (API,
UI/UX, performance, etc) that could appear in a changelog. Write "None"
if there is no user-facing change -->

### Docs

<!-- Link to a Docs PR, tracking ticket in Linear, OR write "None" if no
documentation changes are needed. -->

### Description

viz. microsoft/vcpkg#47084 and
#1442

@ethanmusser has been working on adding MCAP to vcpkg - adding a note to
the README about this.



<!-- Describe the problem, what has changed, and motivation behind those
changes. Pretend you are advocating for this change and the reader is
skeptical. -->

<!-- In addition to unit tests, describe any manual testing you did to
validate this change. -->

<table><tr><th>Before</th><th>After</th></tr><tr><td>

<!--before content goes here-->

</td><td>

<!--after content goes here-->

</td></tr></table>

<!-- If necessary, link relevant Linear or Github issues. Use `Fixes:
foxglove/repo#1234` to auto-close the Github issue or Fixes: FG-### for
Linear isses. -->

---------

Co-authored-by: Ethan J. Musser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants