-
Notifications
You must be signed in to change notification settings - Fork 165
cpp: Document the mcap vcpkg port #1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpp: Document the mcap vcpkg port #1442
Conversation
|
The vcpkg package is not supported by this repo's maintainers, so I don't think it makes sense to link out to it as if it were. I can work on some wording to call it out as a third-party project in the README. |
|
Closing in favor of #1451 |
@james-rms Thanks for putting the link in the README! As an aside, is there any chance of seeing an officially-maintained vcpkg port alongside the already-maintained Conan package? |
|
@ethanmusser not at this time. CMake wrappers are difficult to provide a good user experience for, since everyone needs something a little different there. The goal of the first-party MCAP C++ library is to be easy to integrate into whatever build system you need, CMake or otherwise. |
Darn, figured it was worth asking. I will say that the approach in |
### Changelog <!-- Write a one-sentence summary of the user-impacting change (API, UI/UX, performance, etc) that could appear in a changelog. Write "None" if there is no user-facing change --> ### Docs <!-- Link to a Docs PR, tracking ticket in Linear, OR write "None" if no documentation changes are needed. --> ### Description viz. microsoft/vcpkg#47084 and #1442 @ethanmusser has been working on adding MCAP to vcpkg - adding a note to the README about this. <!-- Describe the problem, what has changed, and motivation behind those changes. Pretend you are advocating for this change and the reader is skeptical. --> <!-- In addition to unit tests, describe any manual testing you did to validate this change. --> <table><tr><th>Before</th><th>After</th></tr><tr><td> <!--before content goes here--> </td><td> <!--after content goes here--> </td></tr></table> <!-- If necessary, link relevant Linear or Github issues. Use `Fixes: foxglove/repo#1234` to auto-close the Github issue or Fixes: FG-### for Linear isses. --> --------- Co-authored-by: Ethan J. Musser <[email protected]>
Changelog
Add a brief blurb and badge referencing the new vcpkg port for mcap in the
README.md.Docs
None
Description
A vcpkg port is in the works in microsoft/vcpkg#47084. This change calls out that port in the
README.mdso that new users are aware that it exists.Draft TODOs