-
Notifications
You must be signed in to change notification settings - Fork 20
Allow cstruct class initialization with definition #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 92.20% 92.21%
=======================================
Files 21 21
Lines 2515 2517 +2
=======================================
+ Hits 2319 2321 +2
Misses 196 196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Note that it doesn't have a I don't think it's necessary but it would be possible to add. |
Can you add it to the |
Don't think it's necessary either, if you require it (or another possible future/advanced argument for |
Done, please check if it describes the change well enough. |
Co-authored-by: Erik Schamper <[email protected]>
This quality of life improvement allows the user to directly initialize a
cstruct
object using a c-definition.This change also enforces that
endian
orpointer
arguments (and future arguments) must be passed using keyword arguments only. It seems that no code base used positional arguments for this before (checked using github codesearch), but this is a breaking change if someone did.Tests are included.
resolves #133