Skip to content

Make collection report consistent #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 18, 2023

Conversation

Miauwkeru
Copy link
Contributor

(DIS-1935)

@Miauwkeru Miauwkeru requested a review from Poeloe July 7, 2023 13:07
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #75 (bd8be69) into main (8bc78d2) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   41.96%   42.00%   +0.03%     
==========================================
  Files          21       21              
  Lines        2702     2700       -2     
==========================================
  Hits         1134     1134              
+ Misses       1568     1566       -2     
Flag Coverage Δ
unittests 42.00% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
acquire/acquire.py 39.24% <ø> (ø)
acquire/collector.py 58.28% <100.00%> (+0.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Miauwkeru Miauwkeru requested a review from Schamper July 10, 2023 13:09
Poeloe
Poeloe previously requested changes Jul 10, 2023
@Miauwkeru Miauwkeru requested a review from Poeloe July 11, 2023 07:07
Copy link
Contributor

@pyrco pyrco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rename the test_glob.py to something more descriptive and more in line with how we want to call our unittest, like test_acquire_modules.py.

@Miauwkeru Miauwkeru force-pushed the DIS-1935_make-collection-report-consistent branch from dad2350 to bd8be69 Compare July 18, 2023 08:06
@Miauwkeru Miauwkeru dismissed stale reviews from Poeloe and Schamper July 18, 2023 08:12

changes implemented

@Miauwkeru Miauwkeru merged commit 5dfee08 into main Jul 18, 2023
@Miauwkeru Miauwkeru deleted the DIS-1935_make-collection-report-consistent branch July 18, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants