Skip to content

Set default value of Options.write_bytes(.., entry = None) #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

Miauwkeru
Copy link
Contributor

The volatile plugins use the collector.collect_command_output, which also used the write_bytes command, however the entry was required. Hence it failed trying to collect that information.

@Miauwkeru Miauwkeru requested review from Schamper and Horofic March 17, 2023 13:07
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #47 (81ee443) into main (7760eb2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   38.97%   38.97%           
=======================================
  Files          21       21           
  Lines        2604     2604           
=======================================
  Hits         1015     1015           
  Misses       1589     1589           
Flag Coverage Δ
unittests 38.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
acquire/outputs/base.py 46.42% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Miauwkeru Miauwkeru requested a review from pyrco March 21, 2023 14:59
@Miauwkeru Miauwkeru merged commit 9133ba8 into main Mar 22, 2023
@Miauwkeru Miauwkeru deleted the DIS-1894_fix-volatile-plugins branch March 22, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants