Skip to content

Improve command line argument validation #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Dec 23, 2022

(DIS-932)

@pyrco pyrco requested review from Schamper and Miauwkeru December 23, 2022 14:29
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #32 (741772b) into main (64f923d) will increase coverage by 1.78%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   34.09%   35.87%   +1.78%     
==========================================
  Files          20       20              
  Lines        2147     2174      +27     
==========================================
+ Hits          732      780      +48     
+ Misses       1415     1394      -21     
Flag Coverage Δ
unittests 35.87% <66.66%> (+1.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
acquire/acquire.py 39.90% <15.00%> (+0.92%) ⬆️
acquire/crypt.py 43.63% <100.00%> (-2.40%) ⬇️
acquire/utils.py 82.99% <100.00%> (+10.54%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pyrco pyrco force-pushed the feature/dis-932_better-argument-validation branch 2 times, most recently from 3daa0e7 to 89d9b1c Compare December 28, 2022 09:39
Schamper
Schamper previously approved these changes Jan 2, 2023
@pyrco pyrco force-pushed the feature/dis-932_better-argument-validation branch from 89d9b1c to 94c40d6 Compare January 3, 2023 15:19
@pyrco pyrco requested review from Schamper and Miauwkeru January 3, 2023 15:19
@pyrco pyrco force-pushed the feature/dis-932_better-argument-validation branch from 94c40d6 to 6b42584 Compare January 3, 2023 15:32
@pyrco pyrco force-pushed the feature/dis-932_better-argument-validation branch from 6b42584 to 741772b Compare January 3, 2023 15:52
@pyrco pyrco merged commit 6d4dace into main Jan 4, 2023
@pyrco pyrco deleted the feature/dis-932_better-argument-validation branch January 4, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants