-
Notifications
You must be signed in to change notification settings - Fork 35
Replace all "dir" and "file" with "path" #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
=======================================
Coverage 44.57% 44.57%
=======================================
Files 26 26
Lines 3527 3527
=======================================
Hits 1572 1572
Misses 1955 1955
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Erik Schamper <[email protected]>
e0b6bab
to
689ad24
Compare
"-f", | ||
"-d", | ||
"--file", | ||
"--dir", | ||
"--path", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only point I'm torn on is if it's worth keeping the arguments around, especially for their shorthand versions. Perhaps we can drop that question with the analysts before removing them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, a good idea
Closes #159