Skip to content

Conversation

Miauwkeru
Copy link
Contributor

@Miauwkeru Miauwkeru commented May 13, 2025

Closes #159

@Miauwkeru Miauwkeru requested a review from Schamper May 13, 2025 14:31
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 30.30303% with 23 lines in your changes missing coverage. Please review.

Project coverage is 44.57%. Comparing base (daf5c82) to head (689ad24).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
acquire/acquire.py 28.12% 23 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   44.57%   44.57%           
=======================================
  Files          26       26           
  Lines        3527     3527           
=======================================
  Hits         1572     1572           
  Misses       1955     1955           
Flag Coverage Δ
unittests 44.57% <30.30%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Schamper Schamper changed the title replace all "dir" and "file" with "path" Replace all "dir" and "file" with "path" May 13, 2025
@Miauwkeru Miauwkeru force-pushed the replace-file-and-dir-with-path branch from e0b6bab to 689ad24 Compare May 14, 2025 07:39
Comment on lines +129 to +133
"-f",
"-d",
"--file",
"--dir",
"--path",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only point I'm torn on is if it's worth keeping the arguments around, especially for their shorthand versions. Perhaps we can drop that question with the analysts before removing them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, a good idea

@Miauwkeru Miauwkeru merged commit 97d7abb into main May 14, 2025
22 of 24 checks passed
@Miauwkeru Miauwkeru deleted the replace-file-and-dir-with-path branch May 14, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSX module InstallHistory.plist file treated as a directory
2 participants