Skip to content

Conversation

qmadev
Copy link
Contributor

@qmadev qmadev commented Mar 7, 2025

Added some additional paths for AV collections.

@Horofic Horofic self-requested a review March 7, 2025 13:54
Co-authored-by: Stefan de Reuver <[email protected]>
@Schamper Schamper requested a review from Copilot March 8, 2025 11:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds new paths to support the collection of AV data from various vendors.

  • Introduces three new AVG paths, two new Avast paths, one new ESET path, one Sophos path, one Trend Micro path, and two new Microsoft-related paths.
  • Adds a comment for the McAfee ePO section to clarify the section header for future reference.

Reviewed Changes

File Description
acquire/acquire.py Added several directory and file paths for AV collection

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

acquire/acquire.py:1037

  • [nitpick] Consider placing the '# McAfee ePO' comment immediately above the corresponding tuple for clearer association and context.
# McAfee ePO

acquire/acquire.py:970

  • Ensure that tests cover the handling of this new AVG directory path so that its integration and expected behavior are validated.
("dir", "sysvol/ProgramData/AVG/Persistent Data/Antivirus/Logs"),

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.49%. Comparing base (38b0648) to head (d54ad4b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   44.49%   44.49%           
=======================================
  Files          26       26           
  Lines        3508     3508           
=======================================
  Hits         1561     1561           
  Misses       1947     1947           
Flag Coverage Δ
unittests 44.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Horofic Horofic merged commit 332a5a4 into fox-it:main Mar 11, 2025
21 of 22 checks passed
@qmadev qmadev deleted the feature/add_av_paths branch March 12, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants