Skip to content

Bring setup.py in line with other projects #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2022
Merged

Bring setup.py in line with other projects #17

merged 1 commit into from
Nov 8, 2022

Conversation

Miauwkeru
Copy link
Contributor

(DIS-1642)

@Miauwkeru Miauwkeru requested a review from pyrco November 8, 2022 13:58
@Miauwkeru
Copy link
Contributor Author

I have the suspicion that use_scm_version overrode the information in pyproject.toml. And seeing that the sed operation changed pyproject.toml the package got the format <name>-<tag>.dev<commits from tag>.<hash>.d<timestamp>

@Miauwkeru Miauwkeru merged commit 56ab831 into main Nov 8, 2022
@Miauwkeru Miauwkeru deleted the DIS-1642_publish-step-creates-wrong-build branch November 8, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pyrco pyrco pyrco approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Miauwkeru @pyrco