Skip to content

Allow multiple targets with acquire #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 26, 2024
Merged

Allow multiple targets with acquire #162

merged 6 commits into from
Apr 26, 2024

Conversation

cecinestpasunepipe
Copy link
Contributor

(DIS-3102)

Poeloe
Poeloe requested changes Mar 29, 2024
View reviewed changes
@Schamper Schamper changed the title allow multiple targets with acquire Allow multiple targets with acquire Apr 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 27.58621% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 41.72%. Comparing base (ec28bcd) to head (d742c2f).
Report is 3 commits behind head on main.

Files Patch % Lines
acquire/acquire.py 4.54% 21 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   41.49%   41.72%   +0.23%     
==========================================
  Files          26       26              
  Lines        3314     3276      -38     
==========================================
- Hits         1375     1367       -8     
+ Misses       1939     1909      -30
Flag Coverage Δ
unittests 41.72% <27.58%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Schamper
Schamper requested changes Apr 15, 2024
View reviewed changes
@cecinestpasunepipe cecinestpasunepipe force-pushed the DIS-3102_Multiple_targets branch from 7aeceb6 to 7713282 Compare April 15, 2024 16:48
@cecinestpasunepipe cecinestpasunepipe marked this pull request as draft April 22, 2024 09:56
@cecinestpasunepipe cecinestpasunepipe marked this pull request as ready for review April 22, 2024 09:56
Poeloe
Poeloe approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Schamper Schamper removed their request for review April 26, 2024 09:31
@cecinestpasunepipe cecinestpasunepipe merged commit 36ab928 into main Apr 26, 2024
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-3102_Multiple_targets branch April 26, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schamper Schamper Schamper approved these changes

@Poeloe Poeloe Poeloe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cecinestpasunepipe @codecov-commenter @Schamper @Poeloe