Skip to content

Add additional SchedLgU.txt paths #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

Horofic
Copy link
Member

@Horofic Horofic commented Jan 23, 2024

(DIS-2136)

@Horofic Horofic requested a review from Poeloe January 23, 2024 08:32
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cab6e2) 44.64% compared to head (00c4f3b) 44.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   44.64%   44.64%           
=======================================
  Files          23       23           
  Lines        2905     2905           
=======================================
  Hits         1297     1297           
  Misses       1608     1608           
Flag Coverage Δ
unittests 44.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper changed the title DIS-2136 Add additional SchedLgU.txt paths Add additional SchedLgU.txt paths Jan 23, 2024
Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! But when merging, please change the commit message, such that it starts with the imperative and put the DIS-* in the body ;)

@Horofic Horofic merged commit 6b076f2 into main Jan 23, 2024
@Horofic Horofic deleted the DIS-2136_additional-schedlgu-paths branch January 23, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants