Skip to content

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Jan 17, 2024

(DIS-2945)

@pyrco pyrco requested a review from Schamper January 17, 2024 12:06
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ff573e8) 44.61% compared to head (efca180) 44.64%.

Files Patch % Lines
acquire/acquire.py 0.00% 1 Missing ⚠️
acquire/collector.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   44.61%   44.64%   +0.03%     
==========================================
  Files          23       23              
  Lines        2896     2905       +9     
==========================================
+ Hits         1292     1297       +5     
- Misses       1604     1608       +4     
Flag Coverage Δ
unittests 44.64% <80.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Schamper
Schamper previously approved these changes Jan 17, 2024
@pyrco pyrco force-pushed the feature/dis-2945_fix-deduplication-on-case-insensitive-targets branch from 4fade27 to f51339f Compare January 17, 2024 12:42
@pyrco pyrco requested a review from Schamper January 17, 2024 12:42
@pyrco pyrco force-pushed the feature/dis-2945_fix-deduplication-on-case-insensitive-targets branch from f51339f to efca180 Compare January 17, 2024 12:54
@pyrco pyrco merged commit 5cab6e2 into main Jan 17, 2024
@pyrco pyrco deleted the feature/dis-2945_fix-deduplication-on-case-insensitive-targets branch January 17, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants