Create volatile profiles #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miauwkeru
force-pushed
the
DIS-2555_create-volatile-profiles
branch
2 times, most recently
from
e86ed5a to
14ed79a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 43.93% 44.45% +0.52%
==========================================
Files 23 23
Lines 2854 2897 +43
==========================================
+ Hits 1254 1288 +34
- Misses 1600 1609 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cecinestpasunepipe
suggested changes
Nov 17, 2023
Miauwkeru
force-pushed
the
DIS-2555_create-volatile-profiles
branch
from
2a289c9 to
774a5a3
Compare
cecinestpasunepipe
suggested changes
Nov 21, 2023
acquire/utils.py
Outdated
| @@ -101,6 +112,7 @@ def create_argument_parser(profiles: dict, modules: dict) -> argparse.ArgumentPa | |||
| parser.add_argument("-l", "--log", type=Path, help="log directory location") | |||
| parser.add_argument("--no-log", action="store_true", help=argparse.SUPPRESS) | |||
| parser.add_argument("-p", "--profile", choices=profiles.keys(), help="collection profile") | |||
| parser.add_argument("--volatile", choices=volatile.keys(), default="none", help="volatile profile") | |||
There was a problem hiding this comment.
--volatile-profile might be more clear otherwise a user enters --volatile and gets.... no volatile.
cecinestpasunepipe
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DIS-2555)