Make collection of non-existent files more clear #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
reviewed
Sep 30, 2022
pyrco
force-pushed
the
feature/dis-962_more-clear-collection-of-non-existent-files
branch
2 times, most recently
from
5ddba84 to
7bc9deb
Compare
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 31.57% 33.23% +1.66%
==========================================
Files 19 19
Lines 2084 2091 +7
==========================================
+ Hits 658 695 +37
+ Misses 1426 1396 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pyrco
force-pushed
the
feature/dis-962_more-clear-collection-of-non-existent-files
branch
4 times, most recently
from
b18d270 to
bf09040
Compare
|
@Schamper Note: I added calls to reporting when a symlink or an unknown file type are collected (they are now reported as a failed collection). |
Schamper
reviewed
Oct 11, 2022
pyrco
force-pushed
the
feature/dis-962_more-clear-collection-of-non-existent-files
branch
from
bf09040 to
db22322
Compare
Schamper
previously approved these changes
Oct 12, 2022
pyrco
force-pushed
the
feature/dis-962_more-clear-collection-of-non-existent-files
branch
from
db22322 to
871aafc
Compare
Schamper
approved these changes
Oct 12, 2022
pyrco
deleted the
feature/dis-962_more-clear-collection-of-non-existent-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DIS-962)