Skip to content

fix(coverage): add coverage only for function call kind #8440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2024
Merged

fix(coverage): add coverage only for function call kind #8440

merged 1 commit into from
Jul 14, 2024

Conversation

grandizzy
Copy link
Collaborator

Motivation

Closes #4311

NodeType::FunctionCall can have different kinds (functionCall, typeConversion, structConstructorCall, others?)

Solution

  • check function call kind and add coverage only if functionCall kind

@grandizzy grandizzy changed the title fix(coverage): count covearge only for function call kind fix(coverage): count coverage only for function call kind Jul 14, 2024
@grandizzy grandizzy marked this pull request as ready for review July 14, 2024 12:25
@grandizzy grandizzy changed the title fix(coverage): count coverage only for function call kind fix(coverage): add coverage only for function call kind Jul 14, 2024
DaniPopes
DaniPopes approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NodeType::FunctionCall can have different kinds (functionCall, typeConversion, structConstructorCall, others?)

https://github.com/ethereum/solidity/blob/64facd4919308dc4f20341ca5016ca8f88a24fe2/libsolidity/ast/ASTAnnotations.h#L333-L338

@grandizzy
Copy link
Collaborator Author

NodeType::FunctionCall can have different kinds (functionCall, typeConversion, structConstructorCall, others?)

https://github.com/ethereum/solidity/blob/64facd4919308dc4f20341ca5016ca8f88a24fe2/libsolidity/ast/ASTAnnotations.h#L333-L338

ah, nice, thanks for pointing it!

@grandizzy grandizzy merged commit 6de15b0 into foundry-rs:master Jul 14, 2024
@grandizzy grandizzy deleted the issue-4311 branch July 14, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@Evalir Evalir Awaiting requested review from Evalir

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(forge): no-effect statements on the stack are not ignored in the coverage report
2 participants
@grandizzy @DaniPopes