Pass details on GasTooHigh #5489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
requested changes
Jul 29, 2023
| #[error("intrinsic gas too high")] | ||
| GasTooHigh, | ||
| #[error("intrinsic gas too high -- {}",.0.detail)] | ||
| GasTooHigh(ErrDetail), |
There was a problem hiding this comment.
Hmm, i think we could have just a String here—if we wanna name it a bit more fancily we can just make a type like type GasErrorDetail = String;.
Evalir
approved these changes
Aug 1, 2023
mattsse
approved these changes
Aug 1, 2023
aathan
added a commit
to aathan/foundry
that referenced
this pull request
Aug 2, 2023
* Pass details on GasTooHigh * Update anvil/src/eth/backend/mem/mod.rs * chore: fmt/clippy --------- Co-authored-by: AA <aa@aa> Co-authored-by: evalir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
GasTooHigh errors were too opaque and I could not tell what was generating the GasTooHigh error.
Solution
Made the GasTooHigh variant a struct with a string that could carry details.