feat(cast): strip WalletOpts and EtherscanOpts from cast subcommands that dont expect a signer or need etherscan api #12705
+45
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskoyo
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
tskoyo
changed the title
DaniPopes
reviewed
Dec 2, 2025
crates/cast/src/cmd/estimate.rs
Outdated
| let provider = utils::get_provider(&config)?; | ||
| let sender = SenderKind::from_wallet_opts(eth.wallet).await?; | ||
|
|
||
| let sender = if let Some(from) = from { |
Member
There was a problem hiding this comment.
idk if this is right, we can probably keep WalletOpts too since we accept it already? @mattsse
Contributor
Author
There was a problem hiding this comment.
I think you're actually right because I just should've removed EtherscanOpts that was used in EthereumOpts
Contributor
Author
|
@DaniPopes , any help with the test failure? I don't see any issue when I run them locally |
Member
|
unfortunately it's just flaky |
DaniPopes
previously approved these changes
Dec 9, 2025
DaniPopes
approved these changes
Dec 9, 2025
Member
|
Thanks! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12394
Motivation
Went through cast subcommands that don't require WalletOpts and EtherscanOpts and removed EthereumOpts.
RpcOpts is the only type that is being used.
Solution
Here's where EthereumOpts is still required:
PR Checklist