Skip to content

Conversation

mablr
Copy link
Contributor

@mablr mablr commented Sep 2, 2025

Motivation

Close #11505

Solution

Updated SizeReport, GasReport, and TestSummaryReport to eliminate report_kind usage to directly check shell.

Unified pattern for table style selection based on shell.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Updated SizeReport, GasReport, and TestSummaryReport to eliminate report_kind usage to directly check shell type for JSON.

Unified pattern for table style selection based on shell.
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes look good to me

RE: CI failures, this is related to an issue on Reth; will re-run the CI once a fix is available and applied

Copy link
Contributor

@0xrusowsky 0xrusowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice to simplify!

@zerosnacks zerosnacks self-requested a review September 3, 2025 10:58
@DaniPopes
Copy link
Member

DaniPopes commented Sep 3, 2025

There's a deadlock with re-entering the global shell here, looking into it

Happens here:

if let Some(gas_report) = gas_report {
let finalized = gas_report.finalize();
sh_println!("{}", &finalized)?;
outcome.gas_report = Some(finalized);
}

@DaniPopes DaniPopes mentioned this pull request Sep 3, 2025
@zerosnacks zerosnacks merged commit b104ef4 into foundry-rs:master Sep 3, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

chore(common): remove unnecessary ReportKind abstraction
5 participants