Skip to content

fix(lint): avoid ANSI chars with JSON emitter #11470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 29, 2025
Merged

fix(lint): avoid ANSI chars with JSON emitter #11470

merged 8 commits into from
Aug 29, 2025

Conversation

0xrusowsky
Copy link
Contributor

Motivation

ref:

Solution

track emitter kind in LintContext and avoid ANSI chars when necessary

@0xrusowsky 0xrusowsky linked an issue Aug 29, 2025 that may be closed by this pull request
forge lint --json has ANSI escape sequences in messages #11460
Closed
2 tasks
DaniPopes
DaniPopes reviewed Aug 29, 2025
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a snapshot test?

@0xrusowsky 0xrusowsky requested a review from DaniPopes August 29, 2025 08:32
@0xrusowsky
Copy link
Contributor Author

@onbjerg can u confirm that this stderr output is the one u expect?

DaniPopes
DaniPopes reviewed Aug 29, 2025
View reviewed changes
@0xrusowsky 0xrusowsky requested a review from DaniPopes August 29, 2025 10:16
@0xrusowsky 0xrusowsky merged commit 56aadcb into master Aug 29, 2025
23 checks passed
@0xrusowsky 0xrusowsky deleted the rusowsky/lint-no-ansi branch August 29, 2025 11:31
@github-project-automation github-project-automation bot moved this to Done in Foundry Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forge lint --json has ANSI escape sequences in messages
2 participants
@0xrusowsky @DaniPopes