fix(invariant): ensure strategy always generates valid sender #11370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya,
zerosnacks and
onbjerg
as code owners
zerosnacks
reviewed
Aug 21, 2025
grandizzy
force-pushed
the
new-tree-expect
branch
from
5207495 to
f8fe275
Compare
grandizzy
changed the title
DaniPopes
reviewed
Aug 21, 2025
| .prop_filter("excluded sender", move |addr| !senders.excluded.contains(addr)) | ||
| .prop_map(move |addr| { | ||
| let mut addr = addr.as_address().unwrap(); | ||
| // Make sure the selected address is not in list of excluded senders. |
There was a problem hiding this comment.
can you link to this pr or issue saying we can't use filter()
There was a problem hiding this comment.
added in 79e1341
DaniPopes
approved these changes
Aug 21, 2025
grandizzy
added a commit
to grandizzy/foundry
that referenced
this pull request
Aug 21, 2025
…y-rs#11370) * fix(invariant): ensure strategy always generates valid sender * Better comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PROPTEST_MAX_LOCAL_REJECTSis reached and is not considered a failure - this doesn't perform all expected runs. In v1.3.0 proptest strategy will stop generate new values and it is reported as a failurePROPTEST_MAX_LOCAL_REJECTSis never reached and all runs performed as expectedSolution
PR Checklist