fix: force 4844 txtype in blobhashes setter #11355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
DaniPopes,
klkvr,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
mattsse
changed the title
This was referenced Aug 19, 2025
zerosnacks
approved these changes
Aug 19, 2025
grandizzy
pushed a commit
to grandizzy/foundry
that referenced
this pull request
Aug 20, 2025
* test: add blobhashes repro * fix: force 4844 tx type
grandizzy
added a commit
that referenced
this pull request
Aug 20, 2025
* fix(lint): explicit message when lint on build failures (#11224) * fix(lint): lint only files that we build (#11247) * fix: force 4844 txtype in blobhashes setter (#11355) * test: add blobhashes repro * fix: force 4844 tx type * fix(forge): handle error if etherscan identifier cannot resolve config (#11356) * fix(forge): handle error if etherscan identifier cannot resolve config * warn on config failures * fix: disable tx gas limit cap (#11347) * fix(forge): write ordered deps in foundry.lock (#11360) * chore: fix clippy (#11361) * chore: bump version 1.3.2 (#11363) * chore: fix cargo deny - update slab to 0.4.11 --------- Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11353
revm has a new check for txtype before returning the blobhash
this forces the tx to 4844 when we set blobhashes