perf: improve InspectorStack #11077
Merged
perf: improve InspectorStack #11077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
DaniPopes
force-pushed
the
dani/evm-perfs-1234
branch
from
33d7aa2 to
d49b096
Compare
DaniPopes
force-pushed
the
dani/evm-perfs-1234
branch
from
d49b096 to
38db3da
Compare
DaniPopes
force-pushed
the
dani/evm-perfs-1234
branch
from
38db3da to
7948c09
Compare
mattsse
approved these changes
Jul 23, 2025
Comment on lines
-819
to
+829
| &mut self.edge_coverage, | ||
| &mut self.cheatcodes, | ||
| &mut self.script_execution_inspector, | ||
| &mut self.chisel_state, | ||
| &mut self.printer, | ||
| &mut self.revert_diag | ||
| &mut self.revert_diag, | ||
| // Keep `cheatcodes` last to make use of the tail call. | ||
| &mut self.cheatcodes, |
There was a problem hiding this comment.
I see, the order never mattered, so we can do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes overhead of
InspectorStackMutReffor step/step_end, the rest of the functions are fine for code dedup.About ~25-30% faster test execution speed.