chore: Fix Mutability Tags for Cheatcodes that are Missing Them #10351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenpaff
reviewed
May 5, 2025
jenpaff
reviewed
May 5, 2025
Mouzayan
force-pushed
the
chore-10027-cheatcode-mutability-tags
branch
from
5f5ec27 to
5d97d85
Compare
Mouzayan
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
…es that need a mutability modifier
…s with no mutability and add mutability checklist
…cheatcode as pure
…test indicating stateful behavior
…ave side effect logic
…gth getMappingSlotAt view
… are external view
… view/pure modifiers
Mouzayan
force-pushed
the
chore-10027-cheatcode-mutability-tags
branch
from
26238e8 to
8ec5aaa
Compare
onbjerg
changed the title
DaniPopes
previously approved these changes
Aug 25, 2025
zerosnacks
previously requested changes
Aug 25, 2025
crates/cheatcodes/spec/src/vm.rs
Outdated
| @@ -594,7 +595,7 @@ interface Vm { | |||
|
|
|||
| /// Utility cheatcode to remove any EIP-2930 access list set by `accessList` cheatcode. | |||
| #[cheatcode(group = Evm, safety = Unsafe)] | |||
| function noAccessList() external; | |||
| function noAccessList() external view; | |||
There was a problem hiding this comment.
This is stateful, imo this should not be view
DaniPopes
previously approved these changes
Aug 26, 2025
grandizzy
approved these changes
Aug 26, 2025
|
Thanks @Mouzayan for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR closes #10027 by reviewing and updating the mutability modifiers (view / pure) on cheatcodes that were previously declared external without an explicit mutability tag.
Motivation
This was a chore tracked in the repo.
Solution
Followed the plan below:
• Identified cheatcodes currently marked external with no view or pure modifier.
• Evaluated each case to determine:
• If the cheatcode mutates observable state (EVM, filesystem, logs, interpreter) → left as-is.
• If the cheatcode reads state but does not mutate → marked as view.
• If the cheatcode has no dependencies or side effects → marked as pure.
• Updated ABI declarations and signatures accordingly.
Note
• Ran
cargo check,cargo clippy, andcargo +nightly fmt --check, all passed.• Ran
cargo test --all --all-featuresmultiple times. Observed inconsistent failures across unrelated tests.• To verify test isolation, ran:
cargo test --all --all-features -- --test-threads=1.With this, previously failing tests (like
decode_traces_with_project_artifacts) passed.PR Checklist