-
Notifications
You must be signed in to change notification settings - Fork 3
Update layout and routing #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideIntegrates updated Oscilloscope front end and power circuitry by refreshing PCB layout, schematic routing, and KiCad project files File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CloudyPadmal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there several resistors such as R25, R22 etc are in 0805 package instead of 0603? Is that intentional or by mistake?
Also the variable capacitors have rather a wide courtyard. Make it smaller similar to stock footprints in KiCAD and place the capacitors (fixed+variable) close to each other.
I see some ground vias from components exit the pads diagonally, while some straight out. Is there a reason for the difference routing?
Did you check the impedance of the oscilloscope traces are matched to 50 Ohms? I see that almost all the traces are 0.2 mm.
The orientation of switch labels POWER and RESET are different from one another. The labels aren't even center aligned with the switches. Please focus on the aesthetics and fix those issues.
Yes, I went with the 0805 package, as currently there is only a 0805-based 6k resistor available on LCSC.
Ok! I will update this in the schematic.
I did this mostly based on the spacing around the component, and in order to avoid the silkscreen getting cut. However, I will work on the design a bit more and update this to ensure more consistency in this regard throughout the design.
Oh, thanks for pointing this out!
Ok! I will update these in the layout. Other notable changes in this commit are 2450AT18A100: https://www.lcsc.com/datasheet/C89334.pdf
Also, I have updated the pin assignment of the main MCU for cleaner routing and increased the number of analog GPIO. |
|
Regarding the 6k resistors only being available in 0805 indicates that there will be trouble sourcing them. Please replace those resistors with a more commonly available resistor (preferably with a closer but different resistor value) |
Hi @CloudyPadmal, As discussed in this issue, we want the total impedance to be close to 3.2k: And we want the ratio between the resistors to be 3:5 to achieve the required gain for our output to be in the range 150mV-3.15V So, I searched using these parameters The common values between 5.1k-7k are: However, none of the resistor pairs are available This is the reason I went with the 6k resistor However, Another Idea I have is that we could maybe use 2 X 3k resistors in series. |
|
Sorry, my bad, 6.12k is in fact not available |
|
Regarding the layout, it mostly looks good except the ADC pin caps (C40/C41). They must be as close as possible to the actual pin on the MCU. The op-amp output resistors (R28/R29) should be kept close to the op-amp; the trace between R28/29 and C40/41 can be long-ish. |
|
The op-amp rails should be decoupled with 100 nF close to the pins (3.3V and -2V). C29 is too far away; it should be within a few mm. |
Should be fine. Make sure to keep them very close together in that case, especially in the op-amp feedback network. The op-amp inputs are less critical; we can afford mode space between the 3ks there. |
|
The GDTs' ground should be connected directly to the BNC shells, not via signal ground vias. Edit: Or even better, keep the vias but also add a wide path directly to the nearest BNC ground leg. |
|
There is currently a single ground layer. We need to separate the two analog and digital ground planes. Please fix that too. |
|
Does the old hardware have separate analog and digital ground planes, @CloudyPadmal? Why do they need to be separate? |
|
That is to reduce digital switching transient ground currents from contaminating the analog circuitry. I'm not 100% sure if the old hardware has it, it might. |
Hey, @CloudyPadmal |
|
Hi @Tejasgarg The most sensitive analog circuit that we need to protect from transients is at the top right. So, we can have a ground pour that covers that region you have marked in a yellow square and have a small connection or two to connect with the rest of the ground plane. What do you think? |
|
Yes, this looks correct |
Hey, @bessman! |
|
Always place the capacitor closer to the IC pins, not the resistor. The two channels are almost identical. Why not make the layout symmetric? |
The location of C29 is fine for the MCU. The op-amps in the scope input need their own decoupling caps close to their power rails. |
Ok! I will keep this in mind. Thanks!
Yes, as pointed out by @bessman as well during the meet. |
Ok! understood, thanks :) |
This is switched to 2X 3k resistors in series, which are 0402 package with 0.1% tolerance.
This is fixed now!
I have gone over the entire schematic and tried to make it so that almost all the ground pads are exited diagonally
I have changed this to 0.35 mm traces for all the oscilloscope lines.
This is also fixed! |
I have tried to reduce the distance between C40/41 to the MCU below 10 mm while also keeping the capacitor ground tied to the analog ground pour. |
Now each power rail of the op amps has an individual 100nF decoupling capacitor.
This is fixed, thanks for the suggestion :)
This is fixed as well! Also, Now both the input channels are symmetric and mirror images of each other to maximise the optimal use of space. |
CloudyPadmal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no silkscreen around the components other than on the sides (have a look at the silkscreen render). Therefore a diagonally exiting ground via makes no sense. They also increase the length of the ground traces compared to a directly exiting trace.
Please remove all the diagonal ground traces and make them straight and place the vias closer to the pad (but not over the pad).
I really think they're still too far away. With ~10 mm of trace between the ADC pin and the cap, the inductance will cause large sampling kickback which will increase the settling time and potentially cause crosstalk. If we can't get them closer than this without significant rearrangement, let's fab a prototype with this layout and see how it behaves. It might be OK for single MHz bandwidth. |
Looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that the switch labels are facing downwards while all the other silkscreen labels are predominantly facing upwards. Rotate POWER and RESET switch labels by 180 degrees and make them center aligned with the mid point of switches.
There is also a discontinuity at the mid of CH2_IN line. Please fix that too.
Hi @CloudyPadmal!
Hey @bessman,
Rotated and center aligned these. Also noticed that it was actually showing up fine on my KiCad
Fixed! |





































































This is a work in progress, and I will be updating this with the complete routing.
This PR aims to update the layout and routing for the board with updates from the Oscilloscope front end and power circuitry.
Summary by Sourcery
Update PSLab mini PCB layout and routing, synchronise schematics with oscilloscope frontend and power circuitry updates, and add the 2450AT18D0100001E component’s 3D model and footprint.
Enhancements: