Skip to content

Conversation

GiovaGa
Copy link

@GiovaGa GiovaGa commented Jun 2, 2021

I didn't find the file where I should add my contribution name, I couldn't find any file named locale_credits.
Before merging, I should add my contribution there.

GiovaGa and others added 5 commits June 2, 2021 17:12
fixes "Error: Found item String/delaction_dialog_msg more than one time"
escape apostrophes \'
@forrestguice
Copy link
Owner

forrestguice commented Jun 2, 2021

I've done a quick review and made a few repairs. Thank you for the good work.
I should get around to merging this in a couple days, and will tag a patch release this weekend.

By the way, the locale_credits is a value in default strings.xml. I went ahead and added something in the appropriate location, but feel free to change this to whatever you like.

#675

@forrestguice forrestguice added this to the v0.13.11 milestone Jun 2, 2021
@GiovaGa GiovaGa marked this pull request as ready for review June 3, 2021 13:10
@GiovaGa
Copy link
Author

GiovaGa commented Jun 3, 2021

Thank you for the fixes, I think it is ready to be merged

@forrestguice forrestguice merged commit 55b85db into forrestguice:master Jun 4, 2021
@forrestguice forrestguice mentioned this pull request Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants