Skip to content

Conversation

verdulo
Copy link
Contributor

@verdulo verdulo commented Mar 27, 2019

I completed the translations (sorry for delay). I also changed Polish name of application to "Czasy Słońca" (exact translation) and added file "name.txt" to metadata.

I have problems with:
alarmAction_timeout (Timeout): this is not button, but title of notification "The alarm timed out.", yes?
What is the difference between configLabel_alarms_silenceAfter (Go silent after) and configLabel_alarms_timeoutAfter (Timeout afte)?
What is difference between "Dismiss" and "Silence" in alarm_hardwarebutton_actions_display?

@forrestguice
Copy link
Owner

np. I'll merge this a little later today.

alarmAction_timeoutMsg is the actual notification message. Its also displayed briefly as a Toast.
I think alarmAction_timeout is currently unused (should probably be removed), but its original context was as a button (menu or notification).

There is also "silence" feature that is currently disabled/hidden. When an alarm is sounding its possible to silence the sound (but keep the alarm/notification active), which is subtly different than having the alarm timeout or dismissed entirely. Its possible to automatically silence after some period (configLabel_alarms_silenceAfter), or use the hardware buttons (to silence from your pocket).

..but while testing I discovered a bunch of bugs here. The hardware buttons don't always works, and I started to question the usefulness of "silence". So those features exist but are basically hidden.

before, after (these look like they might be swapped)
@forrestguice forrestguice added this to the v0.11.1 milestone Mar 27, 2019
@forrestguice
Copy link
Owner

forrestguice commented Mar 27, 2019

What is the difference between ...

Silence stops the sound but the alarm continues in other ways (notifications, vibration, etc).
Dismiss ends the alarm completely (and schedules next alarm if its repeating).
Timeout is basically an automatic dismiss.

#662 #663

@forrestguice forrestguice merged commit 82b32c8 into forrestguice:master Mar 27, 2019

<string name="alarmAction_dismiss">Rezigni</string> <!-- notification action button -->
<string name="alarmAction_snooze">Prokrasti</string> <!-- notification action button -->
<string name="alarmAction_timeout">Silentiĝis</string> <!-- notification action button --> <!-- TODO -->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't used anywhere (so actually safe to remove) - at one point there was an actual "Timeout" button but it was replaced with better UI.

It could be used as a notification title, or as a contentDescription, but should be applicable to a button (verb).

@forrestguice forrestguice mentioned this pull request Mar 28, 2019
@forrestguice forrestguice added translation pl Polish eo Esperanto labels Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eo Esperanto pl Polish translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants