Skip to content

Conversation

pggdt
Copy link
Contributor

@pggdt pggdt commented Oct 18, 2018

Add Chinese translation

pggdt added 2 commits October 18, 2018 17:54
Add Chinese translation
Add Chinese translation
@pggdt pggdt closed this Oct 22, 2018
@pggdt pggdt reopened this Oct 22, 2018
@forrestguice
Copy link
Owner

Hi. Thank you for the translation :) I've been afk all week - I should have some time soon to examine this and get it merged asap.

lint warning "Extra Translation" (translatable="false")
locale_display should contain translated language names (e.g. all language names written in Chinese)

.. not to be confused with locale_display_native where each language is written in its own tongue.
@forrestguice
Copy link
Owner

forrestguice commented Oct 24, 2018

This looks good. I'll merge this now and make a release later this week. It should be on F-Droid soon after that.

I made a few corrections. I removed the values marked translatable="false" to fix the lint warnings. These shouldn't be shadowed/translated (they are usually ENUM names). There also seemed to be some confusion over the locale_display and locale_display_native values. The locale_display array should contain language names all in Chinese.

#680

@forrestguice forrestguice added this to the v0.9.4 milestone Oct 24, 2018
@forrestguice forrestguice merged commit dcadcd3 into forrestguice:master Oct 24, 2018
@forrestguice forrestguice mentioned this pull request Oct 28, 2018
@pggdt
Copy link
Contributor Author

pggdt commented Oct 29, 2018

Thank you very much.

@forrestguice forrestguice added translation zh_TW Traditional Chinese labels Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation zh_TW Traditional Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants