Update Airtel Money rates for 2018 #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kamikazechaser
commented
Oct 24, 2018
kamikazechaser
commented
- Update the rates to the current latest ones
- Update spec to the latest one (0.5)
- Update the rates to the current latest ones - Update spec to the latest one (0.5)
GochoMugo
requested changes
Nov 26, 2018
| { "low": 7501, "high": 10000, "amount": 51 }, | ||
| { "low": 10001, "high": 15000, "amount": 57 }, | ||
| { "low": 15001, "high": 20000, "amount": 60 }, | ||
| { "low": 20001, "high": "+Infinity", "amount": 66 } |
There was a problem hiding this comment.
This should be:
Suggested change
| { "low": 20001, "high": "+Infinity", "amount": 66 } | |
| { "low": 20001, "high": 70000, "amount": 66 } |
Then add another entry after that:
{ "low": 70001, "high": "+Infinity", "amount": -1 }That way the user can know a transaction can not be of a value higher than 70000.
| { "low": 15001, "high": 20000, "amount": 176 }, | ||
| { "low": 20001, "high": 35000, "amount": 187 }, | ||
| { "low": 35001, "high": 50000, "amount": 275 }, | ||
| { "low": 50000, "high": "+Infinity", "amount": 330 } |
There was a problem hiding this comment.
Same applies here as suggested in the earlier comment.
|
Let me see if I can fix the proposed changes soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.