refactor: @W-18185459@ as npm module #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactored code to make it more like a framework @W-18185459@
Co-authored-by: Cristina Cañizales <[email protected]>
chore: wip chore: wip chore: wip chore: wip
madhur310
reviewed
Apr 23, 2025
| run: npm install -g @salesforce/cli | ||
| - name: Display chromedriver version | ||
| run: chromedriver --version | ||
| - name: Setup Fluxbox and Xvfb |
There was a problem hiding this comment.
Got this fix from: SeleniumHQ/selenium#15327 (comment)
madhur310
reviewed
Apr 23, 2025
madhur310
reviewed
Apr 23, 2025
| run: npm ci | ||
| - name: Install Salesforce CLI | ||
| run: npm install -g @salesforce/cli | ||
| - name: Display chromedriver version |
There was a problem hiding this comment.
Technically don't need the Display chromedriver version, seemed like a nice to have - but can remove it if folks don't like it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored code to make it more like a framework
@W-18185459@