Allow setting cpu mode again #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
approved these changes
Aug 26, 2024
|
#157 aims to fix RuboCop. |
The value for `cpu.dig(:model, :name)` is always `nil` since that's the condition in the `if` statement. It was intended to still respect the cpu mode option passed in. Fixes: 7a3a46b ("Prefer CPU host pass through over explicit models")
ekohl
force-pushed
the
fix-setting-cpu-mode
branch
from
ec4c6d0 to
11f3821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value for
cpu.dig(:model, :name)is alwaysnilsince that's the condition in theifstatement. It was intended to still respect the cpu mode option passed in.Fixes: 7a3a46b ("Prefer CPU host pass through over explicit models")