Skip to content

Conversation

Sovietaced
Copy link
Member

@Sovietaced Sovietaced commented Sep 25, 2025

Why are the changes needed?

v1.PodUnknown has been deprecated and unused since 2015. My IDE has warning messages and I figured it should be safe to just cleanup this part of the code.

See: https://pkg.go.dev/k8s.io/api/core/[email protected]#PodUnknown

What changes were proposed in this pull request?

Removes all references to v1.PodUnknown pod phase.

How was this patch tested?

Unit tests

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This pull request removes all references to the deprecated pod phase `v1.PodUnknown`, which has been unused since 2015. The updates across multiple files enhance code cleanliness and maintain functionality. Unit tests were added to ensure existing features remain intact.

@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.58%. Comparing base (6e343cd) to head (c13de65).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
flyteplugins/go/tasks/plugins/k8s/pod/plugin.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6640      +/-   ##
==========================================
- Coverage   59.92%   58.58%   -1.35%     
==========================================
  Files         708      929     +221     
  Lines       51365    70906   +19541     
==========================================
+ Hits        30783    41541   +10758     
- Misses      18270    26212    +7942     
- Partials     2312     3153     +841     
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.13% <ø> (ø)
unittests-flytecopilot 40.87% <ø> (ø)
unittests-flytectl 64.64% <ø> (ø)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 61.09% <50.00%> (-0.01%) ⬇️
unittests-flytepropeller 55.06% <ø> (?)
unittests-flytestdlib 63.03% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sovietaced Sovietaced added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Sep 29, 2025
@Sovietaced Sovietaced marked this pull request as ready for review September 29, 2025 07:27
Copy link
Member

@machichima machichima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Sovietaced Sovietaced merged commit 28f9d2c into flyteorg:master Sep 30, 2025
47 of 49 checks passed
@Sovietaced Sovietaced deleted the unknown-pod-deprecated branch September 30, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants