PR for #888 #889
Merged
PR for #888 #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he chart Currently, there are a substantial number of configuration options in the fluentd crd which are not accessible from the chart (most notably for my needs, the `serviceAccountAnnotations` option). This will allow the chart to be used with extensions to the fluentd crd as they are written without backporting uncommonly used options. Signed-off-by: Davis <[email protected]>
Signed-off-by: Davis <[email protected]>
Signed-off-by: Davis <[email protected]>
wenchajun
approved these changes
Aug 23, 2023
benjaminhuo
approved these changes
Aug 23, 2023
|
@Nyefan Nice move! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows arbitrary features from the FluentD CRD to be used as they are developed
Which issue(s) this PR fixes:
Fixes #888
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: