Skip to content

charts/fluent-operator: Add namespace to the ServiceAccount #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TeddyAndrieux
Copy link
Contributor

What this PR does / why we need it:

Add missing namespace from helm chart ServiceAccount

Which issue(s) this PR fixes:

Fixes: #1589

Does this PR introduced a user-facing change?

Properly handle helm deployment using non `default` namespace

Additional documentation, usage docs, etc.:


@TeddyAndrieux TeddyAndrieux force-pushed the bugfix/add-label-on-service-monitor branch from 67bfe59 to be43aee Compare April 28, 2025 16:09
Copy link
Collaborator

@marcofranssen marcofranssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@marcofranssen marcofranssen merged commit 7c0528c into fluent:master Apr 30, 2025
2 checks passed
@TeddyAndrieux TeddyAndrieux deleted the bugfix/add-label-on-service-monitor branch April 30, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ServiceAccount created by the helm chart is missing namespace
2 participants