Add missing multiline ClusterFilter values #1581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @discostur , thanks for your contribution, can you please fix the dco issue before we can merge your codes? |
discostur
force-pushed
the
fix-issue-1580
branch
from
fa12bcb to
f633016
Compare
|
@cw-Guo should be fixed now ;) |
|
thanks for pointing me to the definition of the parser: https://github.com/fluent/fluent-operator/blob/master/apis/fluentbit/v1alpha2/plugins/filter/multiline_types.go#L29-L41 i pushed a new commit wich adds two more missing optional values ... so you can configure everything which can be configured now |
Signed-off-by: Kilian Ries <[email protected]>
Signed-off-by: Kilian Ries <[email protected]>
discostur
force-pushed
the
fix-issue-1580
branch
from
b498d3b to
894cd0b
Compare
cw-Guo
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1580
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: