Skip to content

hack: Fix shellcheck findings in bash scripts #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

marcofranssen
Copy link
Collaborator

https://www.shellcheck.net/

Shellcheck is available as plugin for many IDEA. It prevents common shell script mistakes.

@marcofranssen marcofranssen force-pushed the bash-shellcheck-fixes branch 15 times, most recently from ee188fa to 048bbd2 Compare March 21, 2025 10:37
@marcofranssen
Copy link
Collaborator Author

Build failure expected, I'm not a repo admin, so don't have access to push the image.

@joshuabaird
Copy link
Collaborator

@marcofranssen Would you mind resolving the conflict?

…uent#1523)

Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.29.0 to 0.30.0.
- [Release notes](https://github.com/aquasecurity/trivy-action/releases)
- [Commits](aquasecurity/trivy-action@0.29.0...0.30.0)

---
updated-dependencies:
- dependency-name: aquasecurity/trivy-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@marcofranssen marcofranssen force-pushed the bash-shellcheck-fixes branch from 048bbd2 to 72ad1e6 Compare March 21, 2025 13:43
@marcofranssen
Copy link
Collaborator Author

Done

@joshuabaird joshuabaird merged commit a0ea5a1 into fluent:master Mar 21, 2025
9 of 10 checks passed
joshuabaird pushed a commit to joshuabaird/fluent-operator that referenced this pull request Mar 27, 2025
…uent#1523) (fluent#1527)

Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.29.0 to 0.30.0.
- [Release notes](https://github.com/aquasecurity/trivy-action/releases)
- [Commits](aquasecurity/trivy-action@0.29.0...0.30.0)

---
updated-dependencies:
- dependency-name: aquasecurity/trivy-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants