makefile: Remove chmod+x #1521
Merged
makefile: Remove chmod+x #1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files are already commited with the executable bit set for these files Signed-off-by: Marco Franssen <[email protected]>
joshuabaird
approved these changes
Mar 20, 2025
|
Question, I see an approval, but the PR isn't merged yet, is that intentional? No pressure, only asking because I might want to contribute a bit more, having them merged simplifies some parts on my side to not have to go back and forth between branches… Same question for some of the other approved PRs. Are you available on slack? Might be better place to ask this kind of questions 😄 |
I'll merge your other PR's now. Yes, you can find me on Slack (Kubernetes, CNCF, or Fluent). Happy to chat there. |
|
@joshuabaird my handle == @marcofranssen let me try to find you there |
joshuabaird
pushed a commit
to joshuabaird/fluent-operator
that referenced
this pull request
Mar 27, 2025
Files are already commited with the executable bit set for these files Signed-off-by: Marco Franssen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files are already commited with the executable bit set for these files