build-fb-image: Update release documentation #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcofranssen
commented
Mar 19, 2025
marcofranssen
force-pushed
the
automate-release-fluent-bit
branch
2 times, most recently
from
b457a5b to
a909cae
Compare
|
Rebased for reviewing convenience on top of master. |
marcofranssen
commented
Mar 19, 2025
marcofranssen
commented
Mar 19, 2025
Comment on lines
53
to
54
| echo "image-base-tag=$IMAGE_BASE_TAG" >> $GITHUB_OUTPUT | ||
| echo "image-major-minor=$MAJOR_MINOR" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Follow the github actions convention for naming outputs. E.g. see any action outputs. Like the setup-go go-version output or any other popular actions.
This helps also distinguishing the environment variables from the outputs.
marcofranssen
commented
Mar 19, 2025
| * Execute the [bump-fluent-bit-version](https://github.com/fluent/fluent-operator/actions/workflows/bump-fluent-bit-version.yaml) workflow dispatch to generate a PR to update fluent-bit version references in this repo | ||
| * Merge the PR generated by the [bump-fluent-bit-version](https://github.com/fluent/fluent-operator/actions/workflows/bump-fluent-bit-version.yaml) workflow | ||
| * Execute the [build-fb-image](https://github.com/fluent/fluent-operator/actions/workflows/build-fb-image.yaml) workflow dispatch to build and publish the new image | ||
| * Execute the [bump-fluent-bit-version](https://github.com/fluent/fluent-operator/actions/workflows/bump-fluent-bit-version.yaml) workflow dispatch to generate a PR to update fluent-bit version references in this repo |
There was a problem hiding this comment.
This would change once the renovate PR is created. Basically the step would be removed.
|
@marcofranssen I'm working on a PR to re-factor this workflow entirely. Let's hold on merging this and I'll try to combine your changes into my re-factored workflow. |
marcofranssen
force-pushed
the
automate-release-fluent-bit
branch
3 times, most recently
from
e9f3622 to
4b13e0a
Compare
|
Rebased on master and fixed conflicts due to other PR improvements. Diff should be slightly reduced due to that. |
marcofranssen
commented
Mar 21, 2025
marcofranssen
force-pushed
the
automate-release-fluent-bit
branch
2 times, most recently
from
8698144 to
3aef08a
Compare
marcofranssen
force-pushed
the
automate-release-fluent-bit
branch
from
3aef08a to
c418859
Compare
marcofranssen
changed the title
Signed-off-by: Marco Franssen <[email protected]>
marcofranssen
force-pushed
the
automate-release-fluent-bit
branch
from
c418859 to
e59885a
Compare
joshuabaird
approved these changes
Mar 27, 2025
joshuabaird
pushed a commit
to joshuabaird/fluent-operator
that referenced
this pull request
Mar 27, 2025
Signed-off-by: Marco Franssen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Build on top of #1513 and #1514, ensure to merge those PRs first as described in the PR.
#1513 merge using a merge commit.
#1514 merge using a rebase commit.
Then this PR should be rebased, and then it can be merged using a merge commit, that way all commits are nicely maintained to keep traceability of the changes in the repo.
(Sorry kind of a Git perfectionist 😉 trying to document every step I take in dev process.)
This PR will only trigger the workflow if the
cmd/fluent-watcher/fluentbit/VERSIONfile changes on the main branch. This would happen if another PR is merged to main that modifies this file.I updated RELEASE.md as well.
Another PR by @truongnht will follow to automate the updating of that file using
renovate. Once those renovate PRs will be merged the release will happen automatically.resolves #1510