Adding namespaceClusterFbCfg to ClusterFluentBitConfig custom resource. #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btalakola
force-pushed
the
add-namespace-to-cluster-fbcfg
branch
from
9acf738 to
a420a61
Compare
benjaminhuo
reviewed
Oct 23, 2024
charts/fluent-operator/values.yaml
Outdated
| @@ -387,7 +387,10 @@ fluentbit: | |||
| parsers: | |||
| javaMultiline: | |||
| # use in filter for parser generic springboot multiline log format | |||
| enable: false | |||
| enable: | |||
There was a problem hiding this comment.
the enable: false shouldn't be changed
There was a problem hiding this comment.
Reverted enable: false value.
There was a problem hiding this comment.
Could you please review this again?
…espace. If it is not defined, it is in the namespace of the fluent-operator. Signed-off-by: Bharathi Talakola <[email protected]> Signed-off-by: btalakola <[email protected]>
…espace. If it is not defined, it is in the namespace of the fluent-operator. Signed-off-by: Bharathi Talakola <[email protected]> Signed-off-by: btalakola <[email protected]>
btalakola
force-pushed
the
add-namespace-to-cluster-fbcfg
branch
from
57347ef to
8276465
Compare
benjaminhuo
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy fluent-bit configmap and secret in the namespace provided in the namespaceClusterFbCfg which is used in ClusterFluentBitConfig customresource > spec section. If it is not defined, they are created in the namespace of the fluent-operator.
Signed-off-by: Bharathi Talakola [email protected]
What this PR does / why we need it:
At present "fluent-bit-config" secret is getting created in the fluent-operator namespace by default. It can be configured using "namespace" key from ClusterFluentBitConfig CRD but this namespace key is not configured at the CR level.
https://github.com/fluent/fluent-operator/blob/release-3.2/charts/fluent-operator/charts/fluent-bit-crds/crds/fluentbit.fluent.io_clusterfluentbitconfigs.yaml#L191-L231.
Hence added namespace field to ClusterFluentBitConfig customresource > spec section.
Which issue(s) this PR fixes:
Fixes: #1365
Does this PR introduced a user-facing change?
None
Additional documentation, usage docs, etc.: