Set explicit fluent-bit name label selector #1293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rmvangun you'll need to sign your commit git commit -s --amend |
Signed-off-by: Ryan VanGundy <[email protected]>
rmvangun
force-pushed
the
fix-servicemonitor-fluentbit-selector
branch
from
4a8e65c to
949056f
Compare
benjaminhuo
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The fluent-bit service is created with a hardcoded label, https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-fluentBit.yaml#L9
This seems reasonable? So I added this to the ServiceMonitor selector as well, and removed the use of the fluent-operator labels.
Which issue(s) this PR fixes:
Fixes #1292
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: