Skip to content

bug: Missing build args in fluentd docker image #1094

@sarathchandra24

Description

@sarathchandra24

Describe the issue

As per the #1079 this should have been a tagged build and deployment, but somehow a file change was missing when I made the commit that doesn't uses any run time tags.

As per https://github.com/fluent/fluent-operator/blob/master/.github/workflows/build-fd-image.yaml#L276-L278, if we observe here these build args being passed but not utilized by the image.

To Reproduce

N/A - Not an issue currently but a feature to improve

Expected behavior

Should pass:

ARG BASE_IMAGE=kubesphere/fluentd
ARG BASE_IMAGE_TAG=latest-arm64-base

and utilize it here

FROM ${BASE_IMAGE}:${BASE_IMAGE_TAG}
LABEL Description="Fluentd docker image" Vendor="Fluent Organization" Version=${BASE_IMAGE_TAG}
ENV TINI_VERSION=0.18.0

Your Environment

- Fluent Operator version:
- Container Runtime: Docker 
- Operating system: MacOS 14.3.1 
- Kernel version: Darwin 23.3.0

How did you install fluent operator?

No response

Additional context

No response

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions