Skip to content

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Jan 15, 2025


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@cosmo0920 cosmo0920 added the ok-package-test Run PR packaging tests label Jan 15, 2025
@cosmo0920
Copy link
Contributor Author

cosmo0920 commented Jan 15, 2025

This PR can be done to create Intel Mac packages again:

CPack: -   Building component package: /Users/runner/work/fluent-bit/fluent-bit/build/_CPack_Packages/Darwin/productbuild//Users/runner/work/fluent-bit/fluent-bit/build/fluent-bit-4.0.0-intel/Contents/Packages/fluent-bit-4.0.0-intel-binary.pkg
CPack: -   Building component package: /Users/runner/work/fluent-bit/fluent-bit/build/_CPack_Packages/Darwin/productbuild//Users/runner/work/fluent-bit/fluent-bit/build/fluent-bit-4.0.0-intel/Contents/Packages/fluent-bit-4.0.0-intel-headers.pkg
CPack: -   Building component package: /Users/runner/work/fluent-bit/fluent-bit/build/_CPack_Packages/Darwin/productbuild//Users/runner/work/fluent-bit/fluent-bit/build/fluent-bit-4.0.0-intel/Contents/Packages/fluent-bit-4.0.0-intel-headers-extra.pkg
CPack: -   Building component package: /Users/runner/work/fluent-bit/fluent-bit/build/_CPack_Packages/Darwin/productbuild//Users/runner/work/fluent-bit/fluent-bit/build/fluent-bit-4.0.0-intel/Contents/Packages/fluent-bit-4.0.0-intel-library.pkg
CPack: - package: /Users/runner/work/fluent-bit/fluent-bit/build/fluent-bit-4.0.0-intel.pkg generated.

ref: https://github.com/fluent/fluent-bit/actions/runs/12785651301/job/35641101791?pr=9834#step:4:3393

@cosmo0920 cosmo0920 marked this pull request as ready for review January 15, 2025 09:55
@patrick-stephens patrick-stephens merged commit e9a2f87 into master Jan 15, 2025
58 checks passed
@patrick-stephens patrick-stephens deleted the cosmo0920-align-creation-of-macos-package branch January 15, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required ok-package-test Run PR packaging tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants