log_event_decoder: improved group metadata fields are availability #10151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Alminana <[email protected]>
leonardo-albertovich
requested review from
edsiper,
fujimotos and
koleini
as code owners
When a single event was read and the unpacked record data was copied to the unpacked group record structure it would cause a double free when destroying the decoder. To handle this we need to ensure that the zone pointers in those instances do not match or otherwise re-initialize one to avoid performing the spurious free. Signed-off-by: Leonardo Alminana <[email protected]>
edsiper
deleted the
leonardo-master-log_event_decoder_group_metadata_improvement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the log event decoder logic to ensure that regardless of if the client code chose to receive meta records or not regular records always contain the appropriate group metadata fields to improve the code update process.