Skip to content

Conversation

patrick-stephens
Copy link
Contributor

@patrick-stephens patrick-stephens commented Mar 27, 2025

Resolves #10110 by optimising the Windows container build to remove unnecessary build targets and ensure we build in release mode.

Previously we were building the shared library and examples, along with debug symbols. None of which are required or done by the Linux builds.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Patrick Stephens added 2 commits March 27, 2025 12:00
Signed-off-by: Patrick Stephens <[email protected]>
Signed-off-by: Patrick Stephens <[email protected]>
@patrick-stephens patrick-stephens force-pushed the 10110_windows_container_optimisations branch from 5c964c9 to b6de752 Compare March 27, 2025 12:51
@patrick-stephens patrick-stephens marked this pull request as ready for review March 27, 2025 13:39
@patrick-stephens patrick-stephens merged commit ac025e7 into master Mar 27, 2025
73 checks passed
@patrick-stephens patrick-stephens deleted the 10110_windows_container_optimisations branch March 27, 2025 13:40
yunzvanessa pushed a commit to yunzvanessa/fluent-bit that referenced this pull request Apr 8, 2025
…10136)

* windows: disable unused build targets and optimise container

Signed-off-by: Patrick Stephens <[email protected]>
scne59 pushed a commit to scne59/fluent-bit that referenced this pull request Apr 9, 2025
…10136)

* windows: disable unused build targets and optimise container

Signed-off-by: Patrick Stephens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci ok-package-test Run PR packaging tests packaging Windows Bugs and requests about Windows platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows container builds failing due to lack of disk space
2 participants