string from file function for bad usb #4231
Draft
+30
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p4p1
requested review from
DrZlo13,
gsurkov,
hedger,
nminaylov and
portasynthinca3
as code owners
hedger
reviewed
Sep 23, 2025
| UNUSED(param); | ||
| char buffer[254]; | ||
| size_t read_bytes; | ||
| Storage* storage = furi_record_open("storage"); |
hedger
requested changes
Sep 23, 2025
| char buffer[254]; | ||
| size_t read_bytes; | ||
| Storage* storage = furi_record_open("storage"); | ||
| File* file = storage_file_alloc(storage); |
|
|
||
| line = &line[ducky_get_command_len(line) + 1]; | ||
| if (file) { | ||
| storage_file_open(file, line, FSAM_READ, FSOM_OPEN_EXISTING); |
There was a problem hiding this comment.
missing check if open was successful
|
|
||
| static int32_t ducky_fnc_string_from_file(BadUsbScript* bad_usb, const char* line, int32_t param) { | ||
| UNUSED(param); | ||
| char buffer[254]; |
There was a problem hiding this comment.
This works as a hard limit for file size - I think it should either be documented and checked or much higher
hedger
added
USB
|
Please un-draft when fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
A badusb function to take the content of a file and print it.
/ext/abc.txtVerification
Here is a sample script to test the function:
make sure to place a file named
abc.txtat the root of an sdcard with text inside of it.Checklist (For Reviewer)