nfc: Fix sector overrun in MFC nested dictionary attack

[GMMan]

What's new

• Fixes sector overrun that occurs when running nested dictionary attack on MIFARE Plus X 2k variants in SL1.

Verification

1. Provision a MIFARE Plus X 2k variants in SL1
2. Write a Vingcard credential to the card
3. Read the card as MIFARE Classic

Checklist (For Reviewer)

• PR has description of feature/bug or link to Confluence/Jira task
• Description contains actions to verify feature/bugfix
• I've built this code, uploaded it to the device and verified feature/bugfix

I'm not sure what the actual intended flow is supposed to be when the dictionary attack runs off the end of the card. I assume it would loop back and continue to check the first part of the dictionary, but it could also just move on to nonce collection, although that would involve some refactoring to free up the loaded dictionaries. Probably something for @noproto to clarify.

Edit: I've discovered that the test card in question is actually a MIFARE Plus EV1. Flipper's detection of this is not quite working, and because the card gave the same historical bytes as MIFARE Plus X, it was incorrectly assumed to be that chip.

[noproto]

Possible regression with this PR or 3822 for Hardnested. Waiting on a card I ordered 2 weeks ago to isolate a crash.

edit: 2K cards aren't recognized, which seems like the root cause for any sector overrun?

flipperzero-firmware/lib/nfc/protocols/mf_classic/mf_classic.h

Line 51 in 5fb9558

MfClassicType4k,

[GMMan]

edit: 2K cards aren't recognized, which seems like the root cause for any sector overrun?

flipperzero-firmware/lib/nfc/protocols/mf_classic/mf_classic.h

Line 51 in 5fb9558

MfClassicType4k,

Potentially addressed in #4053

[noproto]

This should be the correct fix for this issue (rather than fixing a byproduct of the crash): noproto/xero-firmware@56fe7b0

Tested and would welcome feedback.

[RebornedBrain]

Hi @GMMan , thanks for your contribution, and sorry for such a long waiting. Could you please take a look at @noproto proposal about this fix and test, whether it works in your case?

[GMMan]

Hi @GMMan , thanks for your contribution, and sorry for such a long waiting. Could you please take a look at @noproto proposal about this fix and test, whether it works in your case?

That code does not crash, but it also causes some keys to not be detected. I've previously mentioned to @noproto that he can open another PR with the new code and I can close this one whenever that PR is made.

[RebornedBrain]

@GMMan nice, thank you! @noproto, could you please open a pr with your fix?

[noproto]

@hedger this is the fix, the PR is out of date: #4048 (comment)

Edit: Opened #4288