bugfix: update trtllm-gen gemm kernel names

[cyx-6]

📌 Description

update trtllm-gen gemm kernel names

🔍 Related Issues

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

• I have installed pre-commit by running pip install pre-commit (or used your preferred method).
• I have installed the hooks with pre-commit install.
• I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

• Tests have been added or updated as needed.
• All tests are passing (unittest, etc.).

Reviewer Notes

[gemini-code-assist]

Summary of Changes

Hello @cyx-6, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug by updating the naming conventions for several TRTLLM-generated GEMM kernels. The changes involve a minor reordering of specific components within the kernel name strings to ensure consistency and correctness, which is crucial for proper kernel selection and execution.

Highlights

• Kernel Name Standardization: Reordered substrings within the gemm_Bfloat16_E4m3E4m3_Fp32 kernel names in csrc/trtllm_gemm_runner.cu to correct their structure by moving the s6_ component.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes incorrect kernel names for trtllm-gen gemm by moving the _s6 component in the name strings. The change is correct and addresses the bug. I've also suggested a refactoring to improve the maintainability of these long kernel names by using a macro, which should prevent similar issues in the future.

[gemini-code-assist]

These long kernel name strings are hard to read and maintain, as evidenced by the bug this PR is fixing. Using a macro to construct them from their constituent parts would improve readability and reduce the chance of similar errors in the future.

#define TRTLLM_FP8_KERNEL_NAME(tile_params, sched_char) \
    "gemm_Bfloat16_E4m3E4m3_Fp32_" tile_params \
    "_cga1x1x1_16dp256b_TN_transOut_noShflA_dsFp8_sched" sched_char "_sm100a"

  static constexpr const char* KERNEL_NAME_HIGH_N_K_RATIO =
      TRTLLM_FP8_KERNEL_NAME("t128x8x128u2_s6_et64x8_m64x8x32", "P");

  static constexpr const char* KERNEL_NAME_LOW_N_K_RATIO =
      TRTLLM_FP8_KERNEL_NAME("t128x32x128u2_s6_et64x32_m64x32x32", "S");

  static constexpr const char* KERNEL_NAME_LARGE_N =
      TRTLLM_FP8_KERNEL_NAME("t128x32x128u2_s6_et64x32_m64x32x32", "P");

  static constexpr const char* KERNEL_NAME_DEFAULT =
      TRTLLM_FP8_KERNEL_NAME("t128x16x128u2_s6_et64x16_m64x16x32", "S");

#undef TRTLLM_FP8_KERNEL_NAME