Skip to content

Conversation

cyx-6
Copy link
Collaborator

@cyx-6 cyx-6 commented Aug 14, 2025

πŸ“Œ Description

πŸ” Related Issues

πŸš€ Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

βœ… Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit (or used your preferred method).
  • I have installed the hooks with pre-commit install.
  • I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

πŸ§ͺ Tests

  • Tests have been added or updated as needed.
  • All tests are passing (unittest, etc.).

Reviewer Notes

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @cyx-6, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code hygiene by removing two outdated and likely redundant formatting scripts: format.sh and scripts/formatter.sh. This cleanup streamlines the project's development environment, presumably in favor of more modern or integrated formatting solutions like pre-commit hooks, ensuring that code formatting is consistently applied without relying on manual script execution.

Highlights

  • Removal of comprehensive formatting script: The comprehensive format.sh script, which managed Python (YAPF, Ruff, Codespell) and C/C++ (clang-format) formatting, including tool installation and version checks, has been completely removed.
  • Removal of simpler formatting script: The simpler scripts/formatter.sh script, which applied clang-format to CUDA/C++ files and black to Python files, has also been deleted.
  • Shift in formatting workflow: The removal of these scripts suggests a shift towards a more automated or integrated code formatting workflow, likely through pre-commit hooks or CI/CD pipelines, as indicated by the PR template's checklist.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes two formatting scripts, format.sh and scripts/formatter.sh. The title indicates they are outdated, but the description lacks details on their replacement. These scripts enforced code quality using tools like ruff, codespell, and clang-format. Removing them without an alternative, like a pre-commit setup, poses a risk to code consistency and quality. It would be beneficial to either include the new configuration in this PR or provide context on the new approach to formatting and linting.

@yongwww yongwww enabled auto-merge (squash) August 14, 2025 00:32
@yongwww yongwww merged commit ef62f2a into flashinfer-ai:main Aug 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants